search

ppy / osu-framework

A game framework written with osu! in mind.
MIT License
1.67k stars 420 forks source link

Allow to overwrite BufferedContainer's TextureShader and inherit from its DrawNode #6395

Open Uncomfy opened 1 month ago

Uncomfy commented 1 month ago

This is needed to allow custom effects to be applied to BufferedContainer without redrawing the internal children.

Companion to https://github.com/ppy/osu/pull/30391

frenzibyte commented 1 month ago

See https://github.com/ppy/osu/pull/30391#discussion_r1811207718. I don't get the "redrawing the internal children" part here. With the osu!-side PR as context, you'll only redraw every time the dim level/colour is changed, so that shouldn't be an issue?

frenzibyte commented 4 weeks ago

Reading https://github.com/ppy/osu/pull/30391#discussion_r1815242461, I can understand why this is required now.