search

ppy / osu-framework

A game framework written with osu! in mind.
MIT License
1.67k stars 420 forks source link

Allow customising `ScrollContainer`'s scrollbar mapping #6415

Closed peppy closed 1 week ago

peppy commented 1 week ago

For use in osu!.

bdach commented 1 week ago

What's the use case?

peppy commented 1 week ago

https://github.com/ppy/osu/pull/30579, sorry was writing things up.

bdach commented 1 week ago

My primary concern with this is that allowing this sort of override makes ScrollbarMovementExtent (which is public) sort of misleading if it is overridden the way it is in the game-side PR, because it will still appear as if the scrollbar can move the entire length of the container if reading that property, while in actuality it cannot.

Thoughts on making that protected instead or something?

peppy commented 1 week ago

We can try, hopefully nothing uses that in other projects.