search

ppy / osu-framework

A game framework written with osu! in mind.
MIT License
1.64k stars 409 forks source link

Textboxes don't allow RTL languages #89

Open osuApi opened 7 years ago

osuApi commented 7 years ago

I have tried to input text in Arabic, Syraic and Hebrew. None of the text actually renders. English and Latin letters are fine.

peppy commented 7 years ago

the "not rendering" part is because a unicode font is not loaded by default.

osuApi commented 7 years ago

I see. Is there any planned support for RTL languages? I imagine that by default it won't work and will just appear incorrectly.

peppy commented 7 years ago

You're welcome to help add support, if that's what you're asking :).

osuApi commented 7 years ago

I'm not really familiar with how the framework currently renders text (and the way I see it is very messy because I'm unfamiliar with the code!) - do you feel like pointing out where it happens? I could try working on it. But don't expect much, I'm a C# noob!

peppy commented 7 years ago

May just be best to wait for someone who is able to help implement it do so. Not a high priority as far as I'm concerned.

osuApi commented 7 years ago

I see. Hopefully it'll be done before the new client is ready-to-go otherwise channels like #arabic will be unusable :)

Could you label this issue please?

ILOVEPIE commented 7 years ago

What font is osu currently using? there's plenty of freely available unicode fonts on http://fonts.google.com

kj415j45 commented 7 years ago

@ILOVEPIE iirc, it is Exo 2 or https://github.com/ppy/osu-framework/tree/master/osu.Framework/Resources/Fonts (?)

benpigchu commented 7 years ago

【 @ILOVEPIE In game, it's Exo 2 for latins, Noto for special characters, FontAwesome for icons and Noto CJK for CJK characters. 】 【 See the font folder under osu-resources 】 【 However, the default font of the osu-framework is OpenSans. 】

ILOVEPIE commented 7 years ago

OpenSans is Unicode compatable, why not default to that for RTL typing?

On Tue, Jul 25, 2017 at 10:39 AM, Ben Pig Chu notifications@github.com wrote:

【 @ILOVEPIE https://github.com/ilovepie In game, it's Exo 2 https://fonts.google.com/specimen/Exo+2 for latins, Noto for special characters, FontAwesome for icons and Noto CJK for CJK characters. 】 【 See the font folder under osu-resources https://github.com/ppy/osu-resources/tree/master/osu.Game.Resources/Fonts 】 【 However, the default font of the osu-framework is OpenSans. 】

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ppy/osu-framework/issues/89#issuecomment-317812579, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQedi2PZdqcPJR9s7JzRB5mpKxXYr67ks5sRihLgaJpZM4KHMJL .

peppy commented 7 years ago

the fonts are already setup correctly. this is not the issue. please focus on the issue.