ppy / osu-infrastructure

37 stars 5 forks source link

Replay handling for imported (and new) `solo_scores` #11

Closed peppy closed 7 months ago

peppy commented 1 year ago

Just documenting some IRL discussion regarding the path forward with migration of the has_replay flag (aka knowing if a score has a replay available), which is currently not present in the new solo_scores schema.

This was decided with the goal of keeping things simple and flexible for now, and may change in the future once we have the systems online.

Current proposal:

Tasks to make this happen:

cc/ @nanaya @smoogipoo

bdach commented 9 months ago

Update web-10 and osu-web replay retrieval to perform fallback lookups

I dunno about web-10 but from the work I've done on replays I believe osu-web should be doing fallbacks for legacy replays already:

https://github.com/ppy/osu-web/blob/e3424e755c5c411c3ba1b1d90c26fe6db62c1f85/app/Http/Controllers/ScoresController.php#L37 https://github.com/ppy/osu-web/blob/e3424e755c5c411c3ba1b1d90c26fe6db62c1f85/app/Http/Controllers/ScoresController.php#L50-L52

peppy commented 9 months ago

web-10 will still need changes after we eventually deploy (stable directly requests replays from a web-10 endpoint), but I won't be applying these until later in the process.

peppy commented 7 months ago

This is completed. Of note, we're not migrating replays across to the new storage for now as they are in a different format and it would be a large task. Can be revisited at a later point in time.