search

ppy / osu-infrastructure

39 stars 5 forks source link

First place scores on user profiles don't consider lazer scores #27

Open bdach opened 6 months ago

bdach commented 6 months ago

In addition, the recent event section doesn't show when a user gets a high rank on a beatmap for lazer scores.

bdach commented 6 months ago

I made this an issue here because it seemed like the best place - feature is likely going to span multiple components.

The key question for me here is what we expect to happen, i.e. are "lazer mode off" rank no. 1s supposed to be accounted separately from "lazer mode on" rank no. 1s? The "no" answer simplifies implementation but kind of violates the "lazer mode off means lazer basically doesn't exist" premise; the "yes" answer addresses that concern but will also make implementation.... interesting?

peppy commented 5 months ago

To keep everyone happy and the toggle working, I'd propose that we just have a second table with lazer mode included in first place considerations, at least for an initial fix. This would also likely make implementation much simpler for us.

bdach commented 5 months ago

Well the current implementation uses four tables (osu_leaders, osu_leaders_fruits, osu_leaders_mania, osu_leaders_taiko), so would that mean four more? Or a new unified one? I think we could even get away with adding a lazer column to each of those...

peppy commented 5 months ago

Since we've been combining things until now, I'd probably lean towards a combined new table for storage.