ppy / osu-performance

Calculates user performance aggregates from scores
GNU Affero General Public License v3.0
241 stars 45 forks source link

Log exceptions immediately #136

Closed smoogipoo closed 3 years ago

smoogipoo commented 3 years ago

Currently when the pp calculator throws an exception, it dies with a non-descript message: image

This makes it something like the following: image Where the exception is at least visible in that last line before the errors.

This isn't really the proper way to do this. I suspect that the entire program's execution was supposed to be wrapped inside an exception handler, but this doesn't seem to be working (/shrug): https://github.com/ppy/osu-performance/blob/f7d7ca236bb2015f3e22304913a19ae719b13c8a/src/performance/main.cpp#L182-L191