Port xexxar's pp changes

ppy / osu-performance

Calculates user performance aggregates from scores

GNU Affero General Public License v3.0

241 stars 45 forks source link

Port xexxar's pp changes #150

Closed smoogipoo closed 3 years ago

smoogipoo commented 3 years ago

[x] https://github.com/ppy/osu/pull/15227

peppy commented 3 years ago

Do we have any method to ensure these changes are accurate? I guess after deploy we can confirm by running osu-tools against users?

smoogipoo commented 3 years ago

I will provide a spreadsheet in the referenced PR, which you can test via osu-tools.

peppy commented 3 years ago

Ah, the spreadsheets are generated using osu-performance aren't they. As long as you're confident that's fine.

smoogipoo commented 3 years ago

Tested osu-tools against the spreadsheet in https://github.com/ppy/osu/pull/15227#issuecomment-962640302 and it matches up, so this is good to go.

raybeanosu commented 3 years ago

Hello, do you know when will the rework updates go live? I was told sometime around 10 UTC, but I didn't find anything related to that myself. I'm new to GitHub, sorry if I asked this in the wrong place.

smoogipoo commented 3 years ago

It will go live once we're ready, not at a specific time. The changes are finalised, however.

raybeanosu commented 3 years ago

Alright, thank you!

peppy commented 3 years ago

As per usual practice, a timeline will be announced on the osu! site via a news post.