Playcount incrementing should check for valid plays

ppy / osu-queue-score-statistics

A queue processor to handle updating general statistics updates from user scores

MIT License

12 stars 11 forks source link

Playcount incrementing should check for valid plays #63

Closed peppy closed 10 months ago

peppy commented 2 years ago

Minimum time played and score (and making sure auto retry mods like perfect cannot result in playcount farming).

frenzibyte commented 2 years ago

Can give this an attempt. Will need stable code given that we want this to match with stable for the time being.

peppy commented 2 years ago

I think there's actually logic within stable itself to define the cutoff, but I couldn't find it immediately. Maybe you'll have more luck than I did.

It's probably fine to start with some logical restrictions and build on them from there. Disabling any mod combinations that can result in completely automated play (ie. "Perfect" + something which hits objects), adding an arbitrary minimum object-hit count (maybe 20 or so? with considerations for beatmaps which may have less than that).

smoogipoo commented 2 years ago

(AudioEngine.Time - SkipBoundary > 8000 || currentScore.Pass) &&
(currentScore.TotalScore > 10000 || currentScore.Pass) && ...

peppy commented 10 months ago

I think we still want this in this year. @bdach maybe a quick one you can tackle?