search

ppy / osu-stable-issues

Report critical osu-stable issues here
60 stars 11 forks source link

Bancho doesn't record PMs to offline users with spaces #1120

Closed ThePooN closed 1 year ago

ThePooN commented 1 year ago

When a message is sent to a Bancho-offline user, Bancho usually returns 401 (no such nick) but still forwards the message to osu-web for recording to database and display on osu-web/osu!lazer.

When the recipient's nickname contains spaces, Bancho still returns 401 but the forwarding process to osu-web fails. Given Bancho is handling the underscore->space conversion due to limitations of the IRC protocol, the issue is most likely on Bancho's end.

Reproduced over IRC with bancho.js

peppy commented 1 year ago

I've fixed this and will deploy sometime later this week or early next week.