diffname will not refreash when switch current game mode(ruleset?)

[cdwcgt]

First use the mania ruleset, then diff name will show something like (4k) (7k) on convert beatmap

and switch to another ruleset like std, (4k) will not disappear.

Pay attention to the current mode and difficulty name

another mode to mania:

mania mode to anothor

only happens under certain circumstances.

The problem disappeared when I entered the editor and re-saved, maybe it has something related with osu!.db

And the calculation of difficulty will also be wrong (mania and std use the same difficulty stars)

osu!db.zip https://osu.ppy.sh/beatmapsets/1960391#mania/4062575 Remo (CV Hanamori Yumiri) - Motto Memory.zip

I think the core of the problem is that it uses std's difficulty algorithm for mania mode

Possible ways to reproduce:

1. Create a std map (maybe need a mania map in set).
2. switch to mania mode (I'm not sure if it works, but it seems necessary to me)
3. Quick save and exit, let the difficulty calculation begin.
4. If the difficulty stars of mania is abnormal, (for me, it is 0 at the beginning, and then calculated as the same of stars in std mode), then should reproduce successfully, if not, redo 3.

possibly related log

stable ``` 2023-05-07T12:13:38: (4130479) difficulty calculation started. 2023-05-07T12:13:38: (4130479) difficulty calculation completed. 2023-05-07T12:13:38: (4130479) difficulty calculation started. 2023-05-07T12:13:38: (4130479) difficulty calculation completed. 2023-05-07T12:13:40: (4130479) difficulty calculation started. 2023-05-07T12:13:40: (4130479) difficulty calculation completed. 2023-05-07T12:13:40: (4130479) difficulty calculation started. 2023-05-07T12:13:40: (4130479) difficulty calculation completed. 2023-05-07T12:13:44: Notification: Saved Beatmap 2023-05-07T12:13:45: (4130479) difficulty calculation started. 2023-05-07T12:13:45: (4130479) difficulty calculation completed. 2023-05-07T12:13:45: (4130479) difficulty calculation started. 2023-05-07T12:13:45: (4130479) difficulty calculation completed. 2023-05-07T12:13:48: (4130479) difficulty calculation started. 2023-05-07T12:13:48: (4130479) difficulty calculation completed. 2023-05-07T12:13:48: (4130479) difficulty calculation started. 2023-05-07T12:13:48: (4130479) difficulty calculation completed. 2023-05-07T12:13:49: Notification: Saved Beatmap 2023-05-07T12:13:50: Notification: Saved Beatmap 2023-05-07T12:13:51: (4130479) difficulty calculation started. 2023-05-07T12:13:51: Attempting to connect to osu-lazer... 2023-05-07T12:13:51: Connected to osu-lazer. 2023-05-07T12:13:52: (4130479) difficulty calculation completed. 2023-05-07T12:13:52: (4130479) difficulty calculation started. 2023-05-07T12:13:54: (4130479) difficulty calculation completed. 2023-05-07T12:13:59: (4130479) difficulty calculation started. 2023-05-07T12:13:59: (4130479) difficulty calculation completed. 2023-05-07T12:13:59: (4130479) difficulty calculation started. 2023-05-07T12:13:59: (4130479) difficulty calculation completed. 2023-05-07T12:15:01: Performing background save.. 2023-05-07T12:15:02: Done! ``` lazer ``` 2023-05-07 12:05:11 [verbose]: Queueing change for local beatmap Remo (CV: Hanamori Yumiri) - Motto Memory (cdwcgt) 2023-05-07 12:05:11 [verbose]: Invalidating working beatmap cache for Remo (CV: Hanamori Yumiri) - Motto Memory (cdwcgt) [Kono sekai o mamoru] ```

[peppy]

Thanks for the suggestion.

As we only have a limited amount of development time focused on osu-stable changes and this is visual only, we have deemed this out of scope of the fixes we are able to apply. It will likely be (or already has been) solved in osu!lazer.