ppy / osu-stable-issues

Report critical osu-stable issues here
60 stars 11 forks source link

Storyboard display different results in editor and Ingame. #1148

Closed wanjiaXG closed 1 year ago

wanjiaXG commented 1 year ago

Client Version: b20230814.3

In Editor: QQ截图20230818211604

In Game: QQ截图20230818211541

peppy commented 1 year ago

Could you explain what you are seeing as wrong?

wanjiaXG commented 1 year ago

Could you explain what you are seeing as wrong?

It looks bright yellow in the editor, but it is pure white in the game.

Or you can see the comparison below.

In Editor: QQ截图20230818215302

In Game: QQ截图20230818215321

aryoadhi commented 1 year ago

Since it's an additive rather than simply overlaying it, doesn't that mean a pure white with additive filter should also appear as pure white in SB editor?

wanjiaXG commented 1 year ago

Since it's an additive rather than simply overlaying it, doesn't that mean a pure white with additive filter should also appear as pure white in SB editor?

Yes, it is obvious that the editor and gameplay use different color mixing methods separately.

peppy commented 1 year ago

Or one is dimmed more than the other? The yellows are completely different.

wanjiaXG commented 1 year ago

Or one is dimmed more than the other? The yellows are completely different.

In the second comparison, it's quite clear that the layers beneath can be displayed in the editor, while in the gameplay, only pure white is shown.In the wiki, the explanation for this command is use of additive color blending, Interpreting it literally, I believe the representation in the gameplay is correct – pure white combined with any color should yield white. However, I cannot be certain about this since the wiki doesn't provide a formula for the algorithm.In the mentioned comparison, the editor only increases the brightness of the area where color is added, which is clearly different from the blending algorithm used in the gameplay.

wanjiaXG commented 1 year ago

Or one is dimmed more than the other? The yellows are completely different.

QQ截图20230819133233 QQ截图20230819133451

peppy commented 1 year ago

It's probably something to do with the background layer in the storyboard being the same as the actual background, so background dim is applied. check the colours of the background – in the editor they are dimmed, which is why the additive blend is not hitting pure white.

wanjiaXG commented 1 year ago

It's probably something to do with the background layer in the storyboard being the same as the actual background, so background dim is applied. check the colours of the background – in the editor they are dimmed, which is why the additive blend is not hitting pure white.

I am unable to investigate the specific reason, I can only find that using the same code results in different results displayed on both sides of the editor and gameplay. I think it's a bug

Walavouchey commented 1 year ago

Storyboard dimming (both in-game and in the editor) works by dimming the colour of each sprite (and the background) separately, rather than dimming everything post-render.

There seems to be some confusion in this thread. This has everything to do with how additive blend mode behaves under the dimming implementation, nothing else.

The editor applies a 30% dim

additive-blend-mode-with-dim

wanjiaXG commented 1 year ago

Storyboard dimming (both in-game and in the editor) works by dimming the colour of each sprite (and the background) separately, rather than dimming everything post-render.

There seems to be some confusion in this thread. This has everything to do with how additive blend mode behaves under the dimming implementation, nothing else.

The editor applies a 30% dim

additive-blend-mode-with-dim

This is too confusing for those who are not familiar with the dimming implementation mechanism in OSU. Now that I understand, thank you for your answer.

wanjiaXG commented 1 year ago

It's probably something to do with the background layer in the storyboard being the same as the actual background, so background dim is applied. check the colours of the background – in the editor they are dimmed, which is why the additive blend is not hitting pure white.

If we don't modify the sprite dim and use a black layer at the top and modify the alpha value of this image to achieve this function, would it be better? I'm not sure about the specific modification difficulty and performance issues, even if the stable is not planned to be implemented, will the lazer fix this issue?

peppy commented 1 year ago

Background dim is a game concept. Please look it up.

It's not a bug.

If you need further help please consider the game forums.