ppy / osu-stable-issues

Report critical osu-stable issues here
59 stars 11 forks source link

Submitting a beatmap with multiple videos in a single difficulty deletes all but the last video #1240

Open Okorin opened 1 week ago

Okorin commented 1 week ago

Would prevent:

replicating: a .osb like this will cause only vids/part2.avi to be in the .osz downloaded

[Events]
//Background and Video events
Video,8940,"vids/part1.avi"
Video,135929,"vids/part2.avi"
Video,201628,"vids/part2.avi"

local folder osz download:

example: https://osu.ppy.sh/beatmapsets/2195167#osu/4644543

example of this state: https://drive.google.com/drive/folders/1IGYzCZAO5S5k5YOQBAw9atA8vl56k1r1?usp=sharing

Used to be possible (and playing the videos seems to work) in stuff like https://osu.ppy.sh/beatmapsets/29157#osu/156352

Just wanna know if this is known and a wontfix or if this is a bug edit: i do not get a warning about unused files or anything when uploading this state. It's very counterintuitive

peppy commented 1 week ago

At what point does the video get deleted?

Also could you try using different filenames (not part1 / part2 ie. anything without a numeric sequence) just to rule that out?

Okorin commented 1 week ago

when you click "download with video" on the beatmap, the osz on the server will only contain the second video

edit: the game never informs you of this deletion, it just wont be there

when you go through file->export package it works as expected

what we tried

will try non-numeric filenames sec

Okorin commented 1 week ago

using a non-numeric name deleted the second video now lol

[Events]
//Background and Video events
0,0,"bg.jpg",0,0
Video,8940,"opening.avi"
Video,135929,"ending.mp4"
Video,201628,"ending.mp4"

Okorin commented 1 week ago

tried to work around by having a video used as a sprite. this also doesn't work as uploading it removes the video offset if they overlap for long enough for some reason?

the video i tried this with: https://drive.google.com/file/d/1C9Y2WiNsopbhlT3l-icMyICK5U564Grz/view?usp=drive_link

Before in the .osu uploading:

Video,8727,"video.avi"
 F,0,0,19114,0
 F,0,19114,96879,1
 F,0,96879,,0
Video,48027,"video.avi"
 F,0,0,141125,0
 F,0,141125,196097,1
 F,0,196097,,0
Video,173974,"video.avi"
 F,0,173974,238834,0
 F,0,238834,261795,1
 F,0,261795,,0

after uploading

Video,0,"video.avi"
 F,0,0,19114,0
 F,0,19114,96879,1
 F,0,96879,,0
Video,0,"video.avi"
 F,0,0,141125,0
 F,0,141125,196097,1
 F,0,196097,,0
Video,173974,"video.avi"
 F,0,173974,238834,0
 F,0,238834,261795,1
 F,0,261795,,0
Okorin commented 1 week ago

we can work around it in this case by just making the entire experience into one bigger video but it may go over the 55mb upload limit for 5 minute songs (?) and is pretty wasteful

Okorin commented 1 week ago

adding another diff and starting the video blocks off with a MY command instead of F ... fixed this particular issue? I do not understand how or why though https://github.com/ppy/osu-stable-issues/issues/1240#issuecomment-2184230098

Video,8894,"video.avi"
 F,0,8894,19114,0
 F,0,19114,96879,1
 F,0,96879,,0
Video,48027,"video.avi"
 F,0,48027,141125,0
 MY,0,48027,141125,3000
 MY,0,70000,,0
 F,0,141125,196097,1
 F,0,196097,,0
Video,173974,"video.avi"
 F,0,173974,238834,0
 MY,0,173974,238834,3000
 MY,0,238834,,0
 F,0,238834,261795,1
 F,0,261795,,0

seems to be retained properly, performance of showing multiple videos at once notwithstanding...

things i'm wondering for now:

peppy commented 1 week ago

i'd heavily recommend you avoid doing this in the first place. treading on new ground where stable doesn't support what you're doing is probably going to inhibit ranking.

Okorin commented 1 week ago

oh. none of what i did was technically declared unrankable. that's why i was doing it to begin with :D

There's https://osu.ppy.sh/beatmapsets/29157#osu/156352 with multiple videos ranked so I'm at least fairly certain at some point in some way, it was supported, which is why i made the issue in the first place

Edit: Well and I made the issue because as far as I can see none of what I did in the beatmap is currently unrankable, but lots of behaviour is unexpected when dealing with it. I don't know if you remember what was and wasn't intended, but multiple things I ran into do seem more like bugs, hence the report here

Edit2 the game also supports playing the videos, uploading the set and including multiple videos or using videos as sprites also works locally but uploading the beatmap messes with the main part involved inconsistently