ppy / osu-stable-issues

Report critical osu-stable issues here
61 stars 11 forks source link

Stats display at results screen appears to show pp increase relative to highest score play, not highest pp play #1259

Open bdach opened 6 days ago

bdach commented 6 days ago

Reported at https://discord.com/channels/188630481301012481/1097318920991559880/1301527520600002612, logging here for posterity. Have not verified claim or looked at code, but it makes sense that this could happen after preserving more than one score per beatmap/mods/user combination.

Scores involved, for reference (were set in succession as far as I can tell):

Could be called as "working as intended", but also as misleading. Not sure.

bdach commented 6 days ago

More screenshots corroborating this provided by user in https://discord.com/channels/188630481301012481/1097318920991559880/1301538758201704569 on another map (mirroring so that they don't disappear in depths of discord cdn purges):

First score: screenshot558

Second score: screenshot560

Third score: screenshot563

Local leaderboard after all three: image

peppy commented 6 days ago

Yeah this sounds like it will need some adjustment in web-10 code.

I'll look at this tomorrow, in theory it should be a very easy fix.