search

ppy / osu-stable-issues

Report critical osu-stable issues here
60 stars 11 forks source link

Audio stutters due to recent environment changes #267

Closed peppy closed 4 years ago

peppy commented 4 years ago

As reported here.

No changes have occurred at osu!'s end and on investigating I cannot find a feasible cause from our code.

Looking for more information from people who can reproduce:

Log files are also appreciated.

VINXIS commented 4 years ago

I had this issue for almost a year now, I'm not sure if you remember but I had made a tweet with this video a couple months ago I think, and after that tweet someone suggested I use InSpectre and it had seemed to fix all of my stuttering issues after I turned off Meltdown and Spectre protection. I can answer all of the questions except for the first one

After this starts happening, can you reproduce it after restarting osu!?

Yes, also tried cutting edge, stable, beta, and fallback. Restarting in any of these gave me these issues

Does it still happen if you completely close discord (including from system tray)?

Yes

Does it happen if you switch audio devices?

Yes, and the following audio drivers I have used are Asus Xonar DSX, Steinberg UR12, and PreSonus AudioBox iOne. The following peripherals I used are Logitech Z506 and Sennheiser HD579 (this should answer the last question too)

Can you see any stutter on the frame display (Ctrl-F11 twice) when this happens?

I had seen this when I had the stutters.

This is a performance.log file I found from May 14, 2019 that I had sent to Nyquill regarding this issue https://cdn.discordapp.com/attachments/515329811091030026/578012216746311680/performance.log

peppy commented 4 years ago

@VINXIS can you still repro this? an updated video would be great if so.

Edit: your video is showing something completely unrelated. it's due to something else running on your PC, and audio is not rewinding. This thread does not concern you. Also, disabling CPU level flags is not going to solve any osu! performance issue. That's absolute nonsense.

VINXIS commented 4 years ago

Really? Is this one related then because I thought they were the same thing or at least connected since they both were fixed for me at the same time, and audio stutters in both cases https://streamable.com/48fib (0:25)

If this one is related I can still try to reproduce it, if not then I'll take my leave

ItzFireable commented 4 years ago

This problem started happening to me after the FPS option changes, the audio rewinds a few seconds back but my GPU usage is ~60-70% on osu! without anything else open (Vega 56) which isn't normal, was ~10% before the change. It only happens on osu!, any other game is completely fine.

Some users have said this only happens after weeks of PC uptime. Please confirm/deny Confirm, although partially (Sometimes helps, sometimes not) After this starts happening, can you reproduce it after restarting osu!? It happens every time, so yes. Does it still happen if you completely close discord (including from system tray)? Yes, it does. Does it happen if you switch audio devices? Happens still.

They stopped right now as I restarted my computer (didn't help before), I'll comment again after it starts happening again (with performance.log and video proof)

peppy commented 4 years ago

Thank you for the GPU util% reports. Please keep tabs over time and let me know when it starts to happen again.

Xella37 commented 4 years ago

~~For me I get these stutters, but also in the game itself. At least once almost every play session. Especially big ones I clearly saw that it was as ifthe game went back in time and forward about 4x. You could see the circles getting bigger and smaller for half a second or so.

I have not restarted my computer in a long time. I've always put it in hibernation as well. I do see problems decrease when I close Dropbox, which might be because of CPU usage. I am not sure if it happens with other games as I don't play too many other, but I haven't experienced something like this in other games yet. Not sure if related to Discord. Will try playing with Discord closed later. I sually play with a Turtle Beach Earforce P11 headset, but sometimes I play with my (?) speakers. I don't think switching audio device has an impact but not 100% sure.~~

Edit: as I continued to read the Tweets, I noticed this is about audio jumping only.

manmathew commented 4 years ago

I almost guarantee that this issue is due to a windows update. I unfortunately haven't pinpointed as to which one, but it absolutely is due to one. I have Windows 7 on my laptop and haven't had any problems at all, Once I started using my desktop with Windows 10, I at first had no issues (my desktop is also more powerful than my laptop). I started using the machine around September, and was on a much older build (my best guess is 1703 or 1709) since I didn't update it from not using it. Once I updated to build 1903, I started having issues. I didn't update osu and start having these issues, it was a Windows update that caused it. Like I said, I'm not sure what update it is, however I pretty much guarantee that it is a Windows update that is causing this problem. Also the problem that I have is the same as what is in VINXIS's second video (the first video is hard to tell if it's the same problem because of hd).

WinterIsPretty commented 4 years ago

I haven't had this problem and I'm running on the recent version of windows. I do have lag spikes but I think that happens due to my computer being bad; it clears out after a while

peppy commented 4 years ago

Note that this thread is not about any "stutters" that aren't related to audio rewinding about 100ms and playing a second time. See the video in the linked tweet for an example.

I need people that can reliably reproduce this so I can do further targeted testing.

WinterIsPretty commented 4 years ago

So only audio not both?

peppy commented 4 years ago

Only audio. See the video and description. This is a very specific request.

manmathew commented 4 years ago

An update. Restarting the pc is the only way to fix the issue since for me it starts later in the osu session. This time I restarted without letting discord open, and I haven't been having any issues for longer than usual. I have tried before without discord, however that was where I closed discord in the tray after windows booted. I currently have discord open, but the rich presence is disabled in osu, and it's running fine so far. So I guess I'll update here later if the problem comes back.

peppy commented 4 years ago

If it comes back, please don't reboot and get in touch so I can get you to run some more checks.

manmathew commented 4 years ago

I wasn't getting any of the rewinding so I tried making the workload on the computer larger by opening more tabs in chrome, photoshop, and streamlabs obs. The chrome tabs and photoshop with a skinning psd didn't do anything, but streamlabs did. It wasn't only when recording, just having it open causes the rewinding to happen. I have 2 35ish second clips on the same map that I produced from this, but idk how much that will help. I haven't rebooted so I'd like to know what I can do from here to help. Also, after closing streamlabs the issue went away, unlike when I closed discord before.

peppy commented 4 years ago

Please upload the clips at least.

manmathew commented 4 years ago

https://drive.google.com/open?id=1Zt6Hg0WnmbWSBD0auWXVKIHaaDb2O68J First clip I still had photoshop open, but as you can see in the second clip, closing it made no difference. https://drive.google.com/open?id=1jukjug035rb0cn6ZEDNB21R6PpeKWlZt

peppy commented 4 years ago

I've made some adjustments to cutting edge, please give it a try after getting into a bad state and see if it helps.

ItzFireable commented 4 years ago

Stutters started happening again, here's a video recording with the stutters + task manager usage + frame display; https://streamable.com/bzkr9

Optimal FPS, 1680x1050 resolution, borderless windowed

peppy commented 4 years ago

Could you please try switching to cutting edge?

manmathew commented 4 years ago

I've updated cutting edge and recorded the experience starting from having discord, chrome, photoshop, streamcompanion, and streamlabs all open. The problem persisted, and so I tried closing them all in reverse order. I did record it on my phone (not with streamlabs) and I'll upload it if my phone allows. For now, I have the performance log to upload in case it helps. performance.log

peppy commented 4 years ago

From your performance log I can see lots of random high frame times, but nothing really repeating. Also performance.log doesn't help with the audio rewind issue, so I'll be waiting for your video.

manmathew commented 4 years ago

https://drive.google.com/open?id=1FM6A53blFfmouISAJgdW5BagcDR4CS1Z Took a while to upload, but now it's there. Not sure why it changed, but yesterday the issue disappeared after closing streamlabs. Also, after restarting, I opened discord and I didn't have the issue, so the rich presence might play a part in the issue.

ItzFireable commented 4 years ago

I just tried cutting edge, GPU usage is still high but framedrops ended.

Edit: Started happening again, didn't fix it. (4 hours)

peppy commented 4 years ago

Is GPU usage only high when osu! is open?

peppy commented 4 years ago

We've pushed a fix to cutting edge to hopefully resolve this. Please test it out.

InvisibleSymbol commented 4 years ago

Just to be sure that you are aware of this, on some systems the latest cutting edge is completely broken (https://clips.twitch.tv/SolidStormyBearFUNgineer) On my personal system this issue only occurred once, never after that (which makes me believe that this is a server side switch...?)

peppy commented 4 years ago

I'm looking for feedback on whether this solved the issue in this thread. Please post other issues as new issues.

peppy commented 4 years ago

Closing as fixed on cutting edge. Other issues will be resolved separately.