search

ppy / osu-stable-issues

Report critical osu-stable issues here
59 stars 11 forks source link

Sort by difficulty not working correctly with updated star-rating. #958

Open Frogsi opened 2 years ago

Frogsi commented 2 years ago

I couldnt find any thread related to this but currently the difficulty sortings are set on the older values, which results in confusion when it comes to the current star-ratings. Has there been any update on this issue if addressed? (Screenshots for reference)

screenshot906 screenshot907

Frogsi commented 2 years ago

Maybe I am out of the loop but the current star-ratings are pulled from the website and thats why? Would explain a lot if its not client bound.

peppy commented 2 years ago

As you suspected, sorting is done using the "local" value in the highlighted area due to technical reasons.

ghost commented 1 year ago

I just noticed this on https://osu.ppy.sh/beatmapsets/948523 as well.

Nomod:

HR:

I understand that this is because the sorting is done using the local SRs, but since the local SRs are the same for the two difficulties (in both the OP's case and mine) and the order is still swapped, this means one of two things:

  1. The displayed SRs are rounded and the SR for Hard is actually slightly higher than Chaoz's Advanced with HR
  2. The displayed SRs are the exact values used internally for sorting and the order of difficulties with equal star ratings is unpredictable because it's not using a stable sorting algorithm

If it's no. 1, it probably can't be easily fixed right now due to the aforementioned technical limitations.

If it's no. 2, it should probably be relatively easy to fix, at least for this edge case. Of course, this would not fix cases where local star ratings actually differ as well.