search

ppy / osu-tools

command line tools to get stuff done
MIT License
105 stars 78 forks source link

Add flashlight attribute and update packages #121

Closed smoogipoo closed 3 years ago

MBmasher commented 3 years ago

Does FlashlightRating have a zero value when Flashlight mod isn't enabled?

smoogipoo commented 3 years ago

No, is that an issue worth fixing? Perhaps it's something to be fixed lazer-side if so.

MBmasher commented 3 years ago

I'm actually not sure. I feel like it makes sense for it to be zero when it's not enabled, although it's a weird case.

peppy commented 3 years ago

I would honestly hope we aren't storing it anywhere when flashlight is off? Seems like a huge waste of resources otherwise.

smoogipoo commented 3 years ago

Originally it wasn't 0 in the difficulty calculator because it wasn't included into SR and so it could be pulled from the base mod combinations (combinations excluding FL).

But now that diffcalc runs over +FL combinations as well, this should be changed osu!-side.

smoogipoo commented 3 years ago

This PR can go in as is in any case.

peppy commented 3 years ago

So we do want to show "flashlight rating" as zero on all outputs from this tool?

smoogipoo commented 3 years ago

I've changed it to not output.