Lazer mods aren't being passed through to diffcalc

ppy / osu-tools

command line tools to get stuff done

MIT License

105 stars 78 forks source link

Lazer mods aren't being passed through to diffcalc #123

Closed apollo-dw closed 4 weeks ago

apollo-dw commented 3 years ago

Commands such as dotnet run -- simulate osu 165967 -m BL don't work correctly at the moment, since mods are trimmed by LegacyHelper.

I'm getting around this locally at the moment by removing the relevant method. Smoogi seemed certain that this would break calculation however I can confirm that osu-tools functions just fine without the method? I can PR the linked branch however I really doubt that this is the correct way to solve this.

stanriders commented 3 years ago

Mods were trimmed as part of mania fixes PR https://github.com/ppy/osu-tools/pull/110

smoogipoo commented 3 years ago

This one’s actually the important one: https://github.com/ppy/osu-tools/pull/113 It has profile test cases in there to compare against. I’m fairly certain it still is required.

Perhaps it’s only the profile command that needs the trimming (it can also likely be done in a better way…).

minisbett commented 1 month ago

Resolved via #216