search

ppy / osu-tools

command line tools to get stuff done
MIT License
105 stars 78 forks source link

Simulate osu!mania scores by accuracy and counts #166

Closed kionell closed 3 weeks ago

kionell commented 2 years ago

Since osu!mania now uses accuracy -> pp system instead of score -> pp, mania score simulation needs to be updated in both osu-tools and osu-tools GUI. However, i heard that you want to revert this change so idk if this pull request is still relevant or not.

kionell commented 2 years ago

Also, is there any reason why in ScoreInfoExtensions all 100's are Ok's, while everywhere else they are Good's?

smoogipoo commented 2 years ago

while everywhere else

Where do you mean?

Chiffario commented 2 years ago

OsuSimulateCommand as one of the cases

kionell commented 2 years ago

Where do you mean?

Oh, at first i thought that this is the case for osu!taiko simulate command and how osu-web displays osu!taiko leaderboard counts, but then I read this and my questions are gone. The only confusing part that I found is in osu!standard simulate command. I mean this command uses greats (for 300's) and goods (for 100's) which is wrong (if i'm not missing anything), because from ScoreInfoExtensions we know that there are should be Ok's.

smoogipoo commented 2 years ago

At one point in time, osu! used to use Great/Good/Meh. These days every non-mania ruleset uses Great/Good/Ok. So the osu! simulate command (and potentially others) is out of date.

minisbett commented 3 weeks ago

I believe this is outdated and implemented by now, so it can be closed.