ppy / osu-tools

command line tools to get stuff done
MIT License
105 stars 78 forks source link

Disable tablet input handler on start #218

Closed stanriders closed 1 month ago

stanriders commented 1 month ago

Some people are having native driver crashes because of OTD being enabled by default

peppy commented 1 month ago

Wouldn't this imply the same thing would happen on lazer? Or is there something specifically different here?

What do the crashes look like?

stanriders commented 1 month ago

Wouldn't this imply the same thing would happen on lazer? Or is there something specifically different here?

What do the crashes look like?

That would happen on lazer too I believe, but there you have a toggle to disable the tablet driver and it wont interfere anymore.

Lazer's tablet driver crashes xp-pen's tablet driver. It was reported by a user, and I didn't really ask for additional details since disabling tablet input in tools is definitely something we'd want to do anyway (because it'd interfere if for example user tries to play the game at the same time as tools are open, or just manufacturers drivers that are open in background being unhappy)

peppy commented 1 month ago

SO just one user, or multiple? "Some people" implies more than one.

Could you please include the raw reports of this issue here so we can actually look to fix it if required? I don't think this kind of change should be made to an auxiliary project like this for one user. If it's an issue with xppen drivers we'd want to apply some kind of fix.

stanriders commented 1 month ago

I didn't consider this important enough, as it's expected that having two drivers for one device isn't a good idea and might lead to one of them breaking, and again disabling tablet input in tools is something that should be done anyway.

I'll ask for more details about the crash

BunnyTub commented 1 month ago

I did have this issue with my Wacom tablet before (kept drivers installed for other uses), but stopped being an issue when I destroyed the drivers and switched to osu!'s OpenTabletDriver, then a bit after that, switched to the OpenTabletDriver daemon (with osu!'s OpenTabletDriver disabled).