search

ppy / osu-tools

command line tools to get stuff done
MIT License
105 stars 78 forks source link

Added Accuracy, Misscount, and Max Combo columns #83

Closed Finadoggie closed 3 years ago

Finadoggie commented 3 years ago

more nice qol, this time with some help from StanR

Finadoggie commented 3 years ago

wait that's not supposed to happen

Finadoggie commented 3 years ago 
dotnet : An error occurred when executing task 'InspectCode'.
At C:\projects\osu-tools\InspectCode.ps1:26 char:1
+ dotnet cake ./build/InspectCode.cake $cakeArguments
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (An error occurr... 'InspectCode'.:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

Error: 
One or more errors occurred. (inspectcode failed with return code 5)
    inspectcode failed with return code 5
Command executed with exception: One or more errors occurred. (inspectcode failed with return code 5)
    inspectcode failed with return code 5

I'm not sure what this error means and/or how to fix it, and the tools work fine when I'm running the commands so idk why it's even firing errors

bdach commented 3 years ago

Please see the "messages" tab in the appveyor CI result. There are some static analysis inspections therein to fix.

Finadoggie commented 3 years ago

bdach and StanR, you guys are lifesavers!

tybug commented 3 years ago

For future reference, "update profilecommand.cs" isn't a very useful commit message. Better to say something like "fix inspection errors", if in fact that's what that commit is doing.

Finadoggie commented 3 years ago

aight, that was just the name it gave all the commits that I didn't name, and I thought it would be assumed that every unnamed update was just a "fix the broken" commit