search

ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
981 stars 383 forks source link

Beatmaps endpoint returns `max_combo` as 0 even on ranked maps #10572

Closed tsunyoku closed 1 year ago

tsunyoku commented 1 year ago

Not to be confused with https://github.com/ppy/osu-web/issues/10566 which removed max_combo for graveyarded maps.

API is consistently returning max_combo as 0 on the beatmaps endpoint (on ranked beatmaps) which seems to be unintended behaviour, as the max_combo data is still stored for ranked beatmaps: image

nanaya commented 1 year ago

that's because the beatmaps table got a max_combo column and its value is used if exists due to one and other things (namely subquery column uses that exact name).