search

ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
981 stars 383 forks source link

header-v4 box shadow is inconsistent across different pages #10579

Closed cl8n closed 1 year ago

cl8n commented 1 year ago

compare: https://osu.ppy.sh/beatmapsets/events - box shadow below first header https://osu.ppy.sh/beatmaps/artists - box shadow is covered by the second header, so it's only visible further to the left and right

most pages end up looking like the latter, which imo is the better option. I think the header should be updated so that this shadow will always be covered by the following content

honestly all of the box shadows that overlap contents of osu-pages look weird to me but maybe that's a bigger/separate issue :thinking:

nanaya commented 1 year ago

I don't think the first one was even intentional. When everything were relative positioned, the shadow was not visible except very slightly on the outside page area. That box shadow can probably just be removed.