ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
981 stars 383 forks source link

Multiplayer rooms are missing their scores #10725

Closed TTTaevas closed 7 months ago

TTTaevas commented 11 months ago

(note I'm only talking about the type of rooms where players play against each other in real time, not the type of room where players have 7 days to play specific maps)

Up until somewhat recently, on the page of a room, the beatmaps (the items) that were played in that room would be displayed Now they simply do not display anymore, and the "Map Count" remains on 0 Example: https://osu.ppy.sh/multiplayer/rooms/413097

Similarly, on the side of the API, the endpoint to get scores from a room's item doesn't seem to work anymore, but it's important to note the undocumented endpoint that is used to list a room's items does work, its playlist array has all the items you'd expect it to have What I mean by "the endpoint to get scores from a room doesn't seem to work anymore" is that it'll always give this as a response: { params: { limit: 50, sort: 'score_desc' }, scores: [], total: 0, user_score: null, cursor: null, cursor_string: null }

So there must be some issue going on with playlist items

notbakaneko commented 11 months ago

I think these rooms don't have their previous score entries migrated to score_links? @nanaya @peppy

nanaya commented 8 months ago

It was some migration failure before (somehow score links aren't created properly) and then the remaining scores got wiped/archived sometime in jan.

peppy commented 7 months ago

I'll track progress in here.

So far I have removed all links to old solo_scores.

I'm currently working on re-importing these scores with ranked=0 so they can be restored in the leaderboards.

peppy commented 7 months ago

All recoverable scores have now been reimported!

TTTaevas commented 7 months ago

Thank you very much!!