Filtering by "Rank Achieved: SS" does not work in mania

ppy / osu-web

the browser-facing portion of osu!

https://osu.ppy.sh

GNU Affero General Public License v3.0

983 stars 386 forks source link

Filtering by "Rank Achieved: SS" does not work in mania #11057

Closed AkiraMorilas closed 7 months ago

AkiraMorilas commented 8 months ago

Screenshot 2024-03-02 at 14-54-07 beatmap listing osu! As shown in screenshot, none of my 36 mania SS ranks appear, despite mania being set as my main gamemode. I am assuming that this is because none of them are lazer SSes(rainbow 300 only)? Would be nice to get a clarification on whether this is a bug or intentional.

bdach commented 8 months ago

Similarly to https://github.com/ppy/osu-infrastructure/issues/27 I'm not sure what should happen. I see basically two outcomes:

We say that this is intended because that's how lazer grades work and it's a wontfix
We add support for filtering on old/new rank based on lazer mode being active (involves changes to osu-queue-score-statistics to store the old rank somewhere, reindexing at least all stable scores, etc.)

bdach commented 8 months ago

@peppy fyi

nanaya commented 8 months ago

adding the legacy rank to index (and updating search field based on lazer mode) is probably enough.

...wait, no, that's not even needed. The rank filtering is done at the last step at the moment.