A few glitched thumbnails of maps on the new website

ppy / osu-web

the browser-facing portion of osu!

https://osu.ppy.sh

GNU Affero General Public License v3.0

981 stars 384 forks source link

A few glitched thumbnails of maps on the new website #3729

Open Celektus opened 6 years ago

Celektus commented 6 years ago

The thumbnails of these maps are glitched on the new site

Same issue as https://github.com/ppy/osu-web/issues/2453 as far as I'm concerned. Would be great if you could fix these quickly

dlynlcmw4aivmjo

nekodex commented 6 years ago

Triggering a regeneration of the covers seems to have fixed them.

We'll probably run a reprocess across all maps at some point but for the time being if anyone notices other maps with this issue, please post them in this issue and we'll manually regenerate them for now!

Gonna leave this issue open until we can run the bulk reprocess across all beatmaps.

tatitatai commented 5 years ago

https://osu.ppy.sh/beatmapsets/751640#taiko/1582345 https://osu.ppy.sh/beatmapsets/707146#taiko/1553641

omkelderman commented 5 years ago

list of beatmap set ids of which a cover.jpg does not exist (but a background does exist):

43
132
48523
55226
89535
90930
114389
228460
241365
243338
252981
262053
286460
297018
304958
305286
330927
347556
360153
374550
388428
396591
413610
437113
694649

cl8n commented 5 years ago

@omkelderman, some of these mapsets don't have backgrounds. they're not supposed to have a cover

omkelderman commented 5 years ago

this list is generated out of a dataset of an application im running, I checked a few manually to see if they had a background and wrongly assumed all of them did, sorry about that. Manually checked all of them and indeed found a few, will edit my prev comment to take those away.

VINXIS commented 5 years ago

heres 2 of them

https://osu.ppy.sh/b/544334 https://osu.ppy.sh/b/1022486

edit: oo the first 1 is in the list of omkelderman's, the second one isn't though

TheMoMan commented 5 years ago

https://osu.ppy.sh/beatmapsets/463701 I want to say this one broke because the background is placed in a /sb directory.

omkelderman commented 5 years ago

few more that have no background on new web, but do have an image on old web:

peppy commented 5 years ago

Regenerate fixed all above except for:

@nekodex

cl8n commented 5 years ago

https://github.com/ppy/osu-web/blob/master/app/Models/BeatmapsetArchive.php#L71 seems like this doesn't need FL_NODIR

NoffyNoffeh commented 5 years ago

https://osu.ppy.sh/beatmapsets/841126#osu/1760392 https://osu.ppy.sh/beatmapsets/887087#fruits/1857287 https://osu.ppy.sh/beatmapsets/576089#osu/1219692 < this one is probably due to the bgs being in an /sb directory

both the third one I linked and the https://osu.ppy.sh/beatmapsets/463701#osu/992956 map linked a few posts above have this issue because of bgs not in the main directory, but they have thumbnails just fine on old web. so it seems there's an issue here with the banner generator for the new website specifically not being able to handle these cases.

nekodex commented 5 years ago

All the broken covers mentioned so far in this issue should now be fixed, with the exception of this one. The encoding of the image filename in this set is SJIS, so that will need to be corrected.

@peppy