search

ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
981 stars 384 forks source link

ScoreV2 plays are not shown as +Scorev2 in recent plays #6186

Closed KevKjef closed 3 years ago

KevKjef commented 4 years ago

Not fully sure if this belongs here, but playing a (ranked) map with ScoreV2 submits the score (as of sometime ago). Because of this your score(s) will also show up under your recent plays, however there is no icon to indicate the score was using ScoreV2.

Here you can see two scores I submitted with ScoreV2 on a short map to illustrate this: screenshot135 And here you can see how my recent plays have no indication that this would be a ScoreV2 play, besides the play not being worth any PP (but there can be a different reason for this): recentsv2 Because there is no indication of ScoreV2, it can be easy to confuse these scores with 'normal' scores.

Something else to mention, related to ScoreV2 plays submitting, is that there is no icon for ScoreV2. Scorev2missingicon If someone has osuplus installed and looks at recent, the mods you played with are 'bumped' one icon to the left (as seen in the picture above).

It would be nice if a ScoreV2 icon could be added, both to make the recent plays section less confusing and fill up the missing texture.

peppy commented 4 years ago

This is a limitation with storage of mods currently. I hope to eventually resolve this but it may take a bit longer due to the nature of database migration.

aticie commented 3 years ago

Any updates on this?

nanaya commented 3 years ago

It looks like the main thing that's missing is the icon design. Apparently there's a whole set of new design for it? Not sure if done though.

peppy commented 3 years ago

if it's just the icon, let's come up with something temporary and get it displaying. @arflyte can we just whack "sv2" or just "v2" in one of the old mod icons to get this ball rolling?

arflyte commented 3 years ago

yeah, let's go with "v2".

peppy commented 3 years ago

Are you able to provide the graphic? :)

arflyte commented 3 years ago

Wait I thought we already had the "v2" mod graphic. I'll get to it.

aticie commented 3 years ago

It looks like the main thing that's missing is the icon design. Apparently there's a whole set of new design for it? Not sure if done though.

Also, the API won't return v2 scores. Tried with these endpoints:

https://osu.ppy.sh/docs/index.html#get-user-scores https://github.com/ppy/osu-api/wiki#apiget_user_recent

Neither returns v2 scores. As a side effect, submitted v2 scores aren't being shown on the website as well.

image

I don't know if this change is intentional or not, I believe API stopped returning v2 scores around OWC 2020. I think there was a discussion about tournament practice scores were being visible to everyone and people didn't want that. But I couldn't find the thread, so I don't know...

I think bringing it back would be good to have.

nanaya commented 3 years ago

Probably this https://github.com/ppy/osu-stable-issues/issues/559

peppy commented 3 years ago

@aticie please open an issue on the linked repository and reference this one. i'm not sure if we will get it fixed in the near future (as it's just adding more variables to the mix while we are trying to move forward with large infrastructure changes) but having this documented would be beneficial.

aticie commented 3 years ago

image

peppy commented 3 years ago

I was proposing making a new issue. The one you linked was already resolved (if you read closely my response was one which was the result of reverting a previous change).

peppy commented 3 years ago

Is this.. still waiting on an icon?

nanaya commented 3 years ago

hi @arflyte please export the icon somewhere

arflyte commented 3 years ago

Gah, I missed this. The mod situation was and is still a lil bit messy now because it's in the middle of a design transition. I'll sort this out today first priority.

arflyte commented 3 years ago

@nanaya uploaded to the repo. It might be tiny slightly off a bit, but we'll go with it for now. Different versions of photoshops exports in a weird funky way.

I need to look into the whole mod icon situation in-depth again.

nanaya commented 3 years ago

@arflyte it seems to be missing drop shadow or maybe I'm looking at wrong folder