search

ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
970 stars 381 forks source link

Scores (in recent scores for instance) should include the "perfect" / "full combo" flag #6329

Closed stanriders closed 4 years ago

stanriders commented 4 years ago

Would be very useful for player's recent scores

peppy commented 4 years ago

Could you explain where you are seeing this? We can't help with your issues if you aren't providing minimal details.

stanriders commented 4 years ago

https://osu.ppy.sh/api/v2/users/6447454/scores/recent beatmap part doesnt have max_combo

notbakaneko commented 4 years ago

Max combo can be retrieved from the beatmap instead; API's function isn't to include everything in the same response.

stanriders commented 4 years ago

Is it that much effort to add? Considering its present in other endpoints' short beatmap struct

peppy commented 4 years ago

If anything we should be providing less information in the beatmap. There should probably be a "perfect" flag is that's not already there, which signifies full combo or not.

stanriders commented 4 years ago

That would work too i guess. Max combo would be more informative, but perfect is better than nothing.

notbakaneko commented 4 years ago

perfect is already part of the score response