search

ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
970 stars 381 forks source link

Profile links in beatmap description break on BSS upload #7051

Open NoffyNoffeh opened 3 years ago

NoffyNoffeh commented 3 years ago

For example on this map,

https://osu.ppy.sh/beatmapsets/1262989#osu/2625234

I put [profile]Aunn[/profile] in the description

but after updating through bss, it changes to plaintext [profile=12613340]Aunn[/profile]. Saving without changes does not fix it. For some reason, this is not an issue when editing it via the website, even when the website adds in the user ID number. It only becomes stuck as plaintext after updating the beatmap from in-game.

tilda commented 3 years ago

Can confirm this is a thing. Just adding a space somewhere random and saving seems to "fix" it, though it does get annoying when you update a lot :p

venix12 commented 3 years ago

Actually, after changes from #6707 [profile]Aunn[/profile] set on website would likely parse to [profile=12613340:1337]Aunn[/profile:1337] (see https://github.com/ppy/osu-web/blob/master/app/Libraries/BBCodeForDB.php#L225-L268), so my guess would be BSS sets that without a proper parsing?

possibly a thing to bring on https://github.com/ppy/osu-stable-issues instead but not really sure

MzudemO commented 3 years ago

This is also an issue with Unicode symbols in descriptions (e.g. ß). Updating the map turns them into the HTML representation (&szlig).

peppy commented 3 years ago

Just to confirm, does manually removing the =user_id part in BSS and saving work correctly?

NoffyNoffeh commented 3 years ago

Yes, it worked when updating from BSS if I removed the =user_id part from the submission window description editor.

NoffyNoffeh commented 3 years ago

Would this be considered part of the same issue as #7219 ? Since both involve special description links breaking on BSS update. Not sure if I should leave this issue open as a separate one or not.

peppy commented 3 years ago

Not 100% sure on that; best leaving them separated for now.

peppy commented 1 year ago

Is this still an issue?

nanaya commented 1 year ago

Unless bbcode handling for submission server has been updated to match current osu-web then I don't think this has been fixed.

dotremilie commented 2 weeks ago

Can you rename the issue back to something with "profile" in it, as I see that searching for open issues with "profile", not finding one and creating a new issue is a common pattern?

peppy commented 1 week ago

Fixing this will probably require the new BSS version. I dunno I want to attempt a fix on phpbb.