ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
983 stars 386 forks source link

"Netherlands Antilles" is recognised as a region on osu! but has no flag #8153

Closed peppy closed 3 years ago

peppy commented 3 years ago

Forwarding from email report:

'Netherlands Antilles' is currently missing a flag due to the new flag image pack.

Netherlands Antilles is made up of Bonaire, Sint Maarten, Sint Eustatius, Saba, and Curacao. The latter one has its own region on osu, while (I assume) all of the other ones are grouped under Netherlands Antilles

Needs some investigation into how we want to resolve.

nanaya commented 3 years ago

There are a few errors on sentry that the database country table (osu_countries) is missing SX and BQ (and should be added?). The flags for those already exist in twemoji. Users still in AN should probably be reassigned.

Otherwise someone should try getting the flag available in twemoji itself first.

peppy commented 3 years ago

I see. Can probably setup an automatic reassign at next bancho login for these users, alongside adding the two new codes. Do those codes cover all of the applicable regions? Is cloudflare still sending AN to us, or does it look like a legacy thing?

nanaya commented 3 years ago

According to wikipedia ("Succeeded by" section) those should be all. Aruba (AW) separated many years before and already in the table.

Is cloudflare still sending AN to us, or does it look like a legacy thing?

Short of asking cloudflare directly, last registered user on AN was in 2012 so it's probably a legacy thing.

giyokon commented 3 years ago

I am aware the Netherlands Antilles should be left as a legacy region (no new members can sign up) however, this does not resolve how users from said region are left flagless. I made a graphic that can be used as the flag; should I push it to twemoji or just locally to osu?

peppy commented 3 years ago

Please be patient. This is on my todo list. All users will be migrated across.

peppy commented 3 years ago

All users have now been migrated to undefined country. On next login they will be reassigned to the correct region.