search

ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
980 stars 383 forks source link

Error downloading old beatmap #8939

Closed xDololow closed 1 year ago

xDololow commented 2 years ago

This map is unable to download: https://osu.ppy.sh/beatmapsets/13758#osu/50686 If you try download from beatmap page, it returns 500 error.

But if you try doing it form beatmap search page it returns this:

Warning: sprintf(): Too few arguments in /var/www/html/S3.php on line 742

Warning: Cannot modify header information - headers already sent by (output started at /var/www/html/S3.php:742) in /var/www/html/d.php on line 109
Nivalyx commented 2 years ago

yeah very old beatmaps that have been Graveyarded for so many years are intentionally made so that they can't be downloaded anymore

http://osu.ppy.sh/community/forums/topics/49310

image

Nivalyx commented 2 years ago

(if you're still curious about this you can try downloading http://osu.ppy.sh/s/13757 which is 1 mapsetid away from the map that you're trying to download for example and you'll get the same result)

respektive commented 2 years ago

There should probably be a better way of communicating this. I think an info box, like it exists on maps that have their audio removed, would probably work well.

xDololow commented 2 years ago

(if you're still curious about this you can try downloading http://osu.ppy.sh/s/13757 which is 1 mapsetid away from the map that you're trying to download for example and you'll get the same result)

You can't even click on username in this one lol

Nivalyx commented 2 years ago

@respektive

There should probably be a better way of communicating this. I think an info box, like it exists on maps that have their audio removed, would probably work well.

there's already such warning for very old Graveyarded beatmaps (like, ~2007/2008) actually but for some reason they don't really show up on newer maps that are affected by this, dunno why :(

image

@xDololow

You can't even click on username in this one lol

the sole factor that determines whether a beatmap is still downloadable or not is their "age" tho, as in "how long has it been since they're last updated" (if i'm not mistaken).

whether the uploader is restricted or not isn't really considered by the system

xDololow commented 2 years ago

whether the uploader is restricted or not isn't really considered by the system

No, the thing is, it's not even working as supposed to. If player restricted, you'll see it. But in this map link not even clickable.

respektive commented 2 years ago

there's already such warning for very old Graveyarded beatmaps (like, ~2007/2008) actually but for some reason they don't really show up on newer maps that are affected by this, dunno why :(

That's interesting, I haven't seen this one before. So i guess the actual issue here is that the warning isn't shown on all unavailable maps.

No, the thing is, it's not even working as supposed to. If player restricted, you'll see it. But in this map link not even clickable.

I believe this is due to the user not actually being restricted, but rather completely deleted. I've seen this a few times before for some very old users. I could be wrong though

abraker95 commented 2 years ago

Going to leave this map here so it can be tracked: https://osu.ppy.sh/beatmapsets/687#osu/4630

As UberFazz#6563 said, it downloads fine but fails to import with this message image

Blooshing commented 2 years ago

I checked the song archive and it doesn't have the mp3 name as audio.mp3, but instead, as 10 Mr.Lonely.mp3, not necessarily sure if this can cause the import failure or if something else is going on @abraker95. (I also tried renaming the audio file and reimporting it but I am not sure how to rename an audio file through 7zip.) :shrug:

peppy commented 1 year ago

I'm running a script in the background to fix this issue. It should be done within a day.