search

ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
981 stars 383 forks source link

Beatmap covers API endpoints return images of the old format for most non-recent graveyard maps #8994

Closed Zyfarok closed 1 year ago

Zyfarok commented 2 years ago

The size of images returned by the beatmaps covers endpoints of the assets API seems to have changed a while ago (since May 26th 2021 with https://github.com/ppy/scthumber/pull/1 ?), but most* graveyard beatmaps that were not updated since then still have the old format.
This includes the card.jpg, card@2x.jpg, list.jpg and list@2x.jpg images. (cover.jpg and slimcover.jpg did not change)

Graveyard maps are often used in tournaments, and the card/list image are used in osu-web, in lazer (?), and by third-parties applications like mappool sheets.
Example of user favourite section where the graveyard maps have a blurrier look due to this : image

Example graveyard map with the new format and image URLs : https://osu.ppy.sh/beatmapsets/1558526 https://assets.ppy.sh/beatmaps/1558526/covers/card.jpg?1636360215 https://assets.ppy.sh/beatmaps/1558526/covers/list.jpg?1636360215 https://assets.ppy.sh/beatmaps/1558526/covers/card@2x.jpg?1636360215 https://assets.ppy.sh/beatmaps/1558526/covers/list@2x.jpg?1636360215 (ranked and loved beatmaps seem to all return this format)

Example graveyard map with the old format and image URLs : https://osu.ppy.sh/beatmapsets/1235496 https://assets.ppy.sh/beatmaps/1235496/covers/card.jpg?1599939054 https://assets.ppy.sh/beatmaps/1235496/covers/list.jpg?1599939054 https://assets.ppy.sh/beatmaps/1235496/covers/card@2x.jpg?1599939054 https://assets.ppy.sh/beatmaps/1235496/covers/list@2x.jpg?1599939054

*: I said most because there seems to be a few exceptions like https://osu.ppy.sh/beatmapsets/1306572 (last updated 22 Nov 2020, yet has the new format)

Side-Note :
Removing timestamp query parameter at the end of the URL seems to give the same result.
What's the use of this timestamp query argument ? Retrieving old covers ?

peppy commented 2 years ago

That is because the beatmaps were graveyarded. The graveyard is for old beatmaps. We don't re-run processes on these.

Zyfarok commented 2 years ago

I understand but there's a lot of high quality graveyard maps (since the loved requirements is/was not that easy to reach and ranking is even harder) and it's sometimes hard to find a ranked map that fits some mappool slot well without being "overused" (used in many other tourneys), which is why a lot of graveyard maps are used in tournaments in particular.

peppy commented 2 years ago

I understand the use case. We may be able to slowly reprocess all beatmaps in the background. I'll add this to my bucket list.

peppy commented 1 year ago

I believe reprocessing of this finished a while back. Please let us know if you find any examples.

Zyfarok commented 1 year ago

Please let us know if you find any examples.

The two example maps linked above are indeed fixed, but all the other graveyards maps in my favorite beatmap list still have the same issue: https://osu.ppy.sh/beatmapsets/609865#mania/1287833 -> https://assets.ppy.sh/beatmaps/609865/covers/list@2x.jpg https://osu.ppy.sh/beatmapsets/748815#osu/1577423 -> https://assets.ppy.sh/beatmaps/748815/covers/list@2x.jpg https://osu.ppy.sh/beatmapsets/837257#osu/1753120 -> https://assets.ppy.sh/beatmaps/837257/covers/list@2x.jpg https://osu.ppy.sh/beatmapsets/630247#osu/1330531 -> https://assets.ppy.sh/beatmaps/630247/covers/list@2x.jpg https://osu.ppy.sh/beatmapsets/417749#osu/904530 -> https://assets.ppy.sh/beatmaps/417749/covers/list@2x.jpg

Was it supposed to have run on really all graveyard beatmaps ?