search

ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
980 stars 383 forks source link

Remove "Delete Beatmap" button for moderators #9774

Closed RockRoller01 closed 1 year ago

RockRoller01 commented 1 year ago

All removals should happen via the bot for logging purposes, there are 0 reasons why anyone should do it with the button. It already happened that people deleted things without using the bot, which lead to no logging.

Okorin commented 1 year ago

IDK if beatmaps have soft-deletes.

If they do, alternative for the "no logging" issue would be enabling moderators to see those, especially if mapthreads are involved see https://github.com/ppy/osu-web/issues/9594

instead of disabling the button, alternatively just adding logging to said button would be a solution as well

RockRoller01 commented 1 year ago

instead of disabling the button, alternatively just adding logging to said button would be a solution as well

at that point the button is the same as the bot, and would need to report back to discord via webhook etc. i dont think its worth maintaining 2 separate systems for this (ASS and osu-web) but thats up to the devs to know

venix12 commented 1 year ago

They literally both use the same workflow (BeatmapsetDelete job).

nanaya commented 1 year ago

The mailing part is bot specific thing. It could technically be moved to web as well so all the bot needs to do would be just hitting the api...

RockRoller01 commented 1 year ago

I don't think it matters much in the end which system is used, as long as it

The point is that all existing systems must fulfill these criteria so people don't use the wrong one. Easiest one probably would be to let it all be handled by the bot considering that its doing all of that already and osu-web would need to paly catch-up

nanaya commented 1 year ago

osu-web is already handling the actual deletion in all cases.