ppy / osu-web

the browser-facing portion of osu!
https://osu.ppy.sh
GNU Affero General Public License v3.0
983 stars 386 forks source link

problems with osu!mania search #9856

Open arzenvald opened 1 year ago

arzenvald commented 1 year ago

example 1 : i am trying to find 5K or more using key>4, and the search result shows multiple keymode maps that includes 4K (or lower). example 2 : i am trying to find 8K maps using key=8, and the search result shows 8K HITSOUND files along with other non-8K mapset.

i feel this very useful advanced search alias can be improved if :

https://osu.ppy.sh/home/news/2021-04-06-mappers-report-march https://github.com/ppy/osu-web/commit/2d4f1e2a414419f77c08cb48ee5de75f982a1f36

nanaya commented 1 year ago

I don't know what's the deal with hitsound thing but otherwise the current behavior seems correct to me. I don't think there's notion of "specific keymode set" at the moment.

arzenvald commented 1 year ago

hitsound difficulty are never meant to be played in the first place, hence i don't think it should messes up search

cl8n commented 1 year ago

I think it would be confusing to have just one criteria work different from all the rest. currently the entire query selects maps where any difficulty matches. if you're searching for maps that are 5 or more keys, why does it matter that some 4K are included in the same mapset?

and then the hitsound thing... I wonder if it's good enough to just check if "hitsound" is in diff name, and not index those for search

arzenvald commented 1 year ago

why does it matter that some 4K are included in the same mapset?

so, currently if you want to search for specific keymode, the majority of results are not what you are trying to look for, hovering the map card one by one might help but chances are you'll stumble upon maps that you are not looking for.

when i say 'majority' of search result, roughly over 50% of the search result are either 4K or Hitsound file of that keymode you're searching, not a whole mapset with specific keymode you're try to look for. so the two different problem creates one large search issue.

cl8n commented 1 year ago

if you want to search for specific keymode, the majority of results are not what you are trying to look for

I'm having a hard time understanding why. those mapsets do include difficulties that meet your criteria, so it would be weird to not include them in the search result.

to be clear, in your keys>4 example, are you saying that you want mapsets including 4K or lower not show up at all? or do you just want the 4K or lower difficulties hidden from the resulting cards?