search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.39k stars 2.29k forks source link

Star ratings are not updated in beatmap carousel display / sorting #10242

Open iSimpFor opened 4 years ago

iSimpFor commented 4 years ago

the rework for taiko is here but it seems like lazer!taiko did not notice, treating star rating as if it was the old calculator osu_2020-09-25_01-43-10 osu_2020-09-25_01-44-58 osu!lazer version: 2020.923.0

bdach commented 4 years ago

I'm pretty sure the base star rating is persisted to DB, which is why the old rating remains everywhere but on the beatmap panel on the carousel, which supports dynamic recalculation. There's no "forgetting" involved here.

Firmatorenio commented 4 years ago

This seems to have been at least partially resolved by #10306 (2020.1005.0), but the icon on top-right of the beatmap display (the left half of the screen), as well as the SR display at the results screen, still show stale SR. Also, the carousel is still sorted by the stale SR.

image image

smoogipoo commented 4 years ago

These are all known, which is why this issue hasn't been closed yet.

bdach commented 4 years ago

Wedge and results screen have been resolved by #10576, but in the mean time set-level icons no longer dynamically update due to performance concerns (#10497). Sorting still broken.

zachmanthethird commented 2 years ago

While I don't think this is a high priority, especially as the song selection screen plans to be redesigned, I'm bumping this from taiko recalculating SR again. This now allows two separate stale SR calculations to be shown alongside the current version. (#18450 carousel is now in my search term list :+1:)

bdach commented 9 months ago

I'm reopening this because https://github.com/ppy/osu/issues/10242#issuecomment-716164415 is still not resolved. Not even sure why the linked PR closed this.