combo counter appears out of place in other rulesets

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

15.46k stars 2.3k forks source link

combo counter appears out of place in other rulesets #10526

Open enoslayd opened 4 years ago

enoslayd commented 4 years ago

Describe the bug: combo counter appears on lower left corner on all ruleset. (maybe intended for now???). Edit: Their animations too are different from stable

Screenshots or videos showing encountered issue: osu!catch

cytosu

osu!mania

osu!lazer version: master

peppy commented 4 years ago

Not sure what you want?

enoslayd commented 4 years ago

in taiko, combo appears at the top of taiko-left.png, in catch, it appears (and move along) with the catcher only and in mania, it is centered on mania stage and can be higher or lower depending on skin.ini

edit: the combo in lower left should only appear like that in standard

Firmatorenio commented 4 years ago

On a sidenote, is there a way to use the new (lazer-default) scoring/combo views while on a legacy skin? Any files I should remove from the skin?

bdach commented 4 years ago

Removing the legacy score font will disable all HUD element lookups:

https://github.com/ppy/osu/blob/daa0a05d9e95ffd0a9994e5da027cbd502a84793/osu.Game/Skinning/LegacySkin.cs#L338-L341

but that might be scoped a bit too wide. In general legacy -> default fallback logic is largely heuristic and should not be relied on.

enoslayd commented 3 years ago

I think the osu catch duplicate combo counter regressed on 2021.514.0

frenzibyte commented 3 years ago

Correct, that's tracked back in #12791.