search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.14k stars 2.25k forks source link

Playfield borders scaling to circle size #10575

Closed vernonlim closed 3 years ago

vernonlim commented 3 years ago

As mentioned in #9484, the playfield border currently is significantly smaller than what players use, due to being at the limits of editor object placement, not the limits of where a circle can be.

To fix this, playfield borders could scale to circle size. What I mean is that the limits of where a circle can be is calculated based on the CS, and then the border is scaled to those limits. This is actually already implemented in the third party client McOsu.

(in McOsu) border in a CS10 map: screenshot96

border with CS4 on the same map: screenshot98

In my opinion this is the best form of playfield borders (better than the static ones in skins), although I am not sure how hard it is to implement.

bdach commented 3 years ago

Applying the adjustment as proposed would probably end up being a simple padding/margin set. The bigger issue here is how to read/calculate the adjustment sanely - we already have quite a few distinct places where the CS formula is used locally. Should probably not be the case with this if at all possible.