ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.55k stars 2.31k forks source link

Importing large std aspire maps crashes game or fails #10578

Open ThatStella7922 opened 4 years ago

ThatStella7922 commented 4 years ago

Describe the crash: If you try to import https://osu.ppy.sh/beatmapsets/1236927 then the game will crash on devices with limited ram amount i assume

Screenshots or videos showing encountered issue: https://streamable.com/vfb704

image 1 image 2 Clear screenshots as streamable compressed the video super hard

osu!lazer version: 2020.1020.0

Logs: Unable to get logs as this phone cant be jailbroken so I can’t just hop into osu!’s data container and grab log files.

Computer Specifications: iPhone X 3GB RAM 64GB storage iOS 14.2 Dev Beta 4

ThatStella7922 commented 4 years ago

I did this on my iPad Pro to test as well since it has double the ram of that iPhone X, and the fact that I’m able to get logs since it’s jailbroken on iPadOS 13.5

The import ended up failing but the game didn’t crash.

Video and logs are in here. https://drive.google.com/drive/folders/1FGKwtHmFjP2VMp7umRRO01060WJSaAJW The video was done with cocoatop running so you can see how much ram lazer used while doing the process, but the logs were retrieved before I redid the video due to a bad recording. (I didn’t show cocoatop in the first recording). And yes, cocoatop is sideways. That’s a problem with it that I haven’t been able to find a fix for.

ericshu6 commented 4 years ago

what version of ios is the ipad running? (just asking)

ThatStella7922 commented 4 years ago

13.5

ericshu6 commented 4 years ago

ill try testing this on my slow tablet (1.5 GB ram)

ThatStella7922 commented 4 years ago

Tested this on my PC. The import succeeds (of course actually loading the beatmaps to look at in autoplay is another issue) with about 4gb of ram used.

Video and logs are in the previously linked google drive folder (here) inside the 'from pc' folder

PC is running windows 10 x64 1909, 16gb of ram, Vega 56. ryzen 5 3600

smoogipoo commented 4 years ago

Guys this discussion is so useless. A 5 second glance at this issue gives enough information.

It's obvious why this is happening, it's OOM and mobile devices can't deal with that. You don't need to test on another tablet. You don't need to confirm.

Locking.