search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.45k stars 2.3k forks source link

Inputs in multiplayer should be ignored until gameplay start #11417

Open bdach opened 3 years ago

bdach commented 3 years ago

This was especially visible in mania - if keys were pressed while the loading layer was showing in MultiplayerPlayer (due to server not permitting gameplay start yet), the player hierarchy under the loading layer seemed to respond while it probably shouldn't (mania key lighting up, and I think key counter as well).

peppy commented 3 years ago

Not sure it's a huge issue to allow key input to work, but I agree that it feels a bit wrong if mouse input is blocked (in the case of rulesets which consume the cursor), so there should be parity of this behaviour at least.

bdach commented 3 years ago

It's a bit of an aesthetic/visual one as well, given that any animations initiated by inputs that happen while waiting for gameplay start don't actually play out until gameplay start is permitted (because the gameplay clock is paused).

peppy commented 3 years ago

Fair enough, they should definitely either play as expected or be disabled.