ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.34k stars 2.28k forks source link

Osu crashes when the active ruleset is removed after a restart #1198

Closed jorolf closed 6 years ago

jorolf commented 7 years ago

Should this happen or should it revert back to the default one?

peppy commented 7 years ago

crashes should never happen. further details would be useful.

jorolf commented 7 years ago

how to: change "Ruleset" in game.ini to a non-existent ruleset

reason: the mod select overlay tries to create an instance of the ruleset which throws an exception https://github.com/ppy/osu/blob/master/osu.Game/Overlays/Mods/ModSelectOverlay.cs#L43

fix: check if the ruleset exists and if not reset it to the default

peppy commented 6 years ago

Closing as duplicate of #1499