search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.37k stars 2.29k forks source link

Hit error graph and key overlay not shown with HUD off #12039

Open fluffetyfluff opened 3 years ago

fluffetyfluff commented 3 years ago

osu!stable currently shows the hit error graph (and key overlay) even while the score overlay is disabled. image

osu!lazer, on the other hand, doesn't show anything. This might be because the option is named "HUD overlay visibility mode" (interestingly enough, the notification still reads "The score overlay is currently disabled"), but I do not think disabling the entire HUD is the point of disabling the score overlay. In my opinion, disabling score is to reduce distractions while playing, but the hit error bar is an integral part of gameplay. image

Is this an intended change?

bdach commented 3 years ago

This might be eventually addressed by either: more skin/HUD customisation options or legacy layouts (https://github.com/ppy/osu/issues/4632), or alternate methods of displaying the error bar (https://github.com/ppy/osu/issues/3209).

I see it as a matter of personal preference. Personally I don't miss the hit error bar one iota (I like having the HUD fully off), but obviously if it is deemed that the general consensus is that it should unconditionally return for everyone, so be it.

Joehuu commented 3 years ago

Duplicate of https://github.com/ppy/osu/issues/11322, and that closed issue is broadly tracked in https://github.com/ppy/osu/issues/4924. @bdach not sure if I should close this as I believe specific issues should be kept open.

fluffetyfluff commented 3 years ago

Ah naturally I forgot to delete is:open when searching the issue tracker. Oops! I think having a separate option to remove the hit error bar might work better (keeping Shift+Tab functionality similar to stable).

bdach commented 3 years ago

I suppose we can keep this open for searchability given it's been reported multiple times now...

peppy commented 3 years ago

The path forward here is likely going to involve adding support to the skin layout editor to let the user choose when certain elements appear. I'm intending to get to this but still figuring out the UX (how things should be exposed/named to provide enough functionality while still keeping it understandable).

Once this is done, the Shift-Tab cycle options would return to a bool selection, with the extra overloaded behaviour coming from the user's layout settings.

LeaPhant commented 11 months ago

Any updates on this? https://github.com/ppy/osu/issues/11322 / https://github.com/ppy/osu/issues/4924 were marked as completed, key overlay got its own toggle in settings but it's still not possible to do the same for hit error graph.

bdach commented 11 months ago

No updates.

key overlay got its own toggle in settings

This just hasn't been moved yet. It'll eventually be moved to skin editor.

ana-rchy commented 9 months ago

bump for wanting more attention on this

cesarila2 commented 6 months ago

Before coming to this issue, I was hoping that the "Playfield ("osu!" only)" would stay enabled when HUD is hidden. As it stands, I'm not sure what the difference between "HUD ("osu!" only)" and "Playfield ("osu!" only)" is supposed to be.

bdach commented 6 months ago

what the difference between "HUD ("osu!" only)" and "Playfield ("osu!" only)" is supposed to be

The playfield layer allows you to attach things to the playfield rather than to corners of the screen. It's not supposed to impact visibility in any way.

peppy commented 6 months ago

The playfield layer allows you to attach things to the playfield rather than to corners of the screen. It's not supposed to impact visibility in any way.

It might actually make sense for things on this layer to be visible always, given they are supposed to be attached to the playfield 🤔 .