ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.65k stars 2.17k forks source link

Using rate on osu!mania seems to break accuracy timing window #12242

Closed AlexHgC closed 3 years ago

AlexHgC commented 3 years ago

Describe the bug:

If you put a rate lower than 1.0 on OD10 ( or lower ) maps like 0.7 for example, the accuracy ( timing windows ) will be a lot more easier, and it's really easy to have MAXs with high OD maps, which is not supposed to be the case.

It's hard to proof what i mean with only screenshot, but when you play OD10 base map 4, and other OD10 harder map with like 0.5 rate for down into 4, you can feel the timing window is a lot more easy, with the same OD/difficulty

First, the score with base map OD8, no modifier : image

The same map OD8 with 0.8 rate : image

And now, the same map with 0.7 rate and OD11 modifier : image

vernonlim commented 3 years ago

lazer mania might be using the same rate algorithm as other modes, which simply changes the game clock, making timing windows tighter/looser for higher/lower rates respectively. in stable, the timing windows are adjusted to keep them the same.

obviously this shouldn't be the case in mania (players will be outraged), so this should be changed if true.

EDIT: for why timing windows shouldn't be affected in mania: DT/HT in stable, player-made rate-changed diffs (in unranked/loved sets) and basically any other VSRG I know of don't change them. thus, not a single experienced mania player expects them to be.

bdach commented 3 years ago

For the record, please avoid statements such as "players will be outraged", because nobody wants that. Stating that it's already the case in stable would have been enough.

AlexHgC commented 3 years ago

So this is not intended ? Because i think this feature doesn't really fit with osu!mania, accuracy is the most important part of this gamemode. Having some different timing windows for the same OD is too weird

smoogipoo commented 3 years ago

This is the case on all timing-based rulesets (i.e. all except catch). If this behaviour changes for mania, it must change for all rulesets.

In the case of osu!, it is already fairly commonly known that DT affects "OD", even if not directly.

smoogipoo commented 3 years ago

Closing this to be tracked under https://github.com/ppy/osu/issues/12248