ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
14.7k stars 2.17k forks source link

Add monospace font #12740

Open gagahpangeran opened 3 years ago

gagahpangeran commented 3 years ago

Mentioned in https://github.com/ppy/osu/pull/12688#issuecomment-832874635

Proposal : Add monospace font.

The for the exact font itself maybe can be discussed here because as @bdach said in https://github.com/ppy/osu/pull/12688#issuecomment-832874635

And a monospace font, as well, but that's a bigger quandary, since web doesn't actually choose one monospace font, but just uses whichever flavour is available on the system:

font-family: Menlo (macOS-specific), Monaco (macOS-specific), Consolas (windows-specific), Courier New (windows-specific), monospace (whatever is left available);

I believe all of the above named fonts are not opentype-licensed, either.

This issue can be closed and merged with #12739 if needed.

peppy commented 3 years ago

There's also a monospace font at framework side Roboto. Have you attempted to use that for the time being?

gagahpangeran commented 3 years ago

Roboto and Roboto Mono are different font in the same Roboto family.

In framework side there are only Roboto and Roboto Condensed.

After take a look into Roboto Mono, I think the font is good enough.

Screenshot from 2021-05-24 14-18-30

peppy commented 3 years ago

Right. Even so, I think it's closer to monospaced to the point where it could be used for the time being? We do that at the framework-side already, as far as I'm aware.

gagahpangeran commented 3 years ago

As a heads up, these are the comparison of using current default Torus font, Roboto font, and Roboto Mono font.

Torus

Screenshot from 2021-06-02 15-25-08

Roboto

Screenshot from 2021-06-02 15-26-20

Roboto Mono

Screenshot from 2021-06-02 15-25-44

If this is okay, I'll add the Roboto Mono font.

bdach commented 3 years ago

The creator of Inter (the web content font) endorsed Roboto Mono as a good monospace pairing for it, so sure.

peppy commented 3 years ago

Looks fine.