ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.45k stars 2.3k forks source link

Beatmap author link is incorrect in beatmap info wedge #12965

Open LeNitrous opened 3 years ago

LeNitrous commented 3 years ago

Describe the bug: The beatmap info wedge map author when clicked sends you to the wrong profile.

This is due to recent API changes that affected BeatmapMetadata which is done in this pull request: https://github.com/ppy/osu-web/pull/7517. The user_id property now uses the difficulty owner set via beatmap discussions but the creator property still uses the beatmap set host.

A suggestion which may be worthwhile is instead of showing mapped by <creator>, it should instead show hosted by <host> and mapped by <creator>. However, the API endpoint responsible for fetching the beatmap metadata only returns the difficulty owner's ID and requires another lookup in the API.

To reproduce:

I'll attempt at fixing this if I can be assigned in this issue.

Screenshots or videos showing encountered issue: ymk4jfaKjo

osu!lazer version: master

Logs: N/A

peppy commented 3 years ago

This is wrong in multiple places, so keep that in mind when looking into a fix (needs to be fixed in the local lookup too).