ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.39k stars 2.29k forks source link

Random mod with non-star effect mod (visually) change star rating. #13453

Open IkaWaAyuMu opened 3 years ago

IkaWaAyuMu commented 3 years ago

Describe the bug: When selecting random mod with other mod that doesn't effect the star rating, the star rating keep changing but stay same with same mod combination. I don't know the actual effect though, I don't know how to check.

I think the Random mod shouldn't effect star rating in any mean, but I don't know what actually behind it :P

Screenshots or videos showing encountered issue:

https://user-images.githubusercontent.com/7066150/121680220-7d175480-cae3-11eb-9be1-9b1c58a2da4c.mp4

osu!lazer version: 2021.608.0

Logs: database.log network.log performance.log performance-audio.log performance-draw.log performance-update.log runtime.log updater.log

peppy commented 3 years ago

Known issue, as it is calculating each random generation. Also not a huge issue. I'm sure you and other users can understand why it's happening, right?

Not even sure if this is worth tracking/fixing to be honest, but let's see what others say.

May be more suited to a discussion.

bdach commented 3 years ago

I think the Random mod shouldn't effect star rating in any mean, but I don't know what actually behind it :P

It very much should affect the star rating. Because the map changes. The objects on it are in a different place.

I also think this is not important enough to realistically matter. May be fine to fix the seed until play start at the most.

okolenmi commented 1 month ago

I think, peppy and bdach didn't undersand the problem. I have 500pp unranked score on a Hard difficulty map, for example: osu_2024-10-07_20-33-47

It was easy, but the game calculated it as 8.65*. It's a problem of star rating calculation.

bdach commented 1 month ago

@okolenmi your issue is #29729, is a recent regression, and is fixed already (fix will be released shortly).