search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.41k stars 2.29k forks source link

Hidden compatibility with Grow/Deflate #13581

Closed Moxanthia closed 3 years ago

Moxanthia commented 3 years ago

As of releases 2021.619.0 and 2021.619.1, the Hidden mod can no longer be selected alongside Grow/Deflate. My primary way of playing has been with these mods together as their combined effects make gameplay look much smoother to me. Maybe this is a bug, but if it was on purpose then I'd hope this change can be reverted as there's no apparent conflict between the two.

bdach commented 3 years ago

It was semi-intentionally done in https://github.com/ppy/osu/pull/13546, because both mods change approach circles. Although it may have been a bit far-reaching in this case as both of the mentioned mods hide the approach circle in more or less the exact same manner.

peppy commented 3 years ago

I'm not against fixing this one, but will need a bit of thought as to how/where the interface should be added to make this work as expected.

enoslayd commented 3 years ago

i also wanna suggest that traceable should be compatible with approach different cause technically, traceable only changes the hit circles and slider itself not the approach circles directly

frenzibyte commented 3 years ago

Traceable completely hides the approach circle, rendering Approach Different useless. Both mods should remain incompatible.

gagahpangeran commented 3 years ago

Traceable doesn't hide approach circle, it hides the circle only.

frenzibyte commented 3 years ago

Okay, I confused it with SpinIn. Traceable should probably not have IMutateApproachCircle assigned to it or be incompatible with them, but be specifically incompatible with mods that hide the approach circle. Will investigate through this.