search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.32k stars 2.28k forks source link

`APIAccess.Friends` does not get updated for the whole session #13604

Open frenzibyte opened 3 years ago

frenzibyte commented 3 years ago

Split from #13493.

Might want to be polled at APIAccess every 5000ms or similar, with a RefetchFriends method invoked upon opening the friends section of dashboard overlay.

peppy commented 3 years ago

What's the intended purpose here? To update online statuses or something else?

frenzibyte commented 3 years ago

Updating APIAcccess.Friends list to match current state, mainly for the dashboard friends display to stay updated.

peppy commented 3 years ago

As in if a user adds a friend from the website or something like that? We probably want to wait for a push based event flow to come online before considering this. I don't think it's important enough to be polling, let alone every 5 seconds. Maybe once every hour, or if decided better, when the overlay is opened.

minasminas commented 3 years ago

As the original issue was opened by me, I would guess the intention here is to update the Online status of the friends list, as they don't update at the moment.

minasminas commented 3 years ago

Are there any news on this one? I ask because I feel like it's not an unimportant one. Just from a player perspective I find it pretty important to relyably know if your friend that you are chatting with really is still online or not. Sucks everytime for me at least when I can't know for sure.

peppy commented 3 years ago

No.

LePenner commented 1 week ago

Are there any updates on this?