Don't allow clicking on on Beatmap Creator when beatmap is not submitted

ppy / osu

rhythm is just a *click* away!

https://osu.ppy.sh

MIT License

15.45k stars 2.3k forks source link

Don't allow clicking on on Beatmap Creator when beatmap is not submitted #14310

Open AlexHgC opened 3 years ago

AlexHgC commented 3 years ago

Describe the bug:

When you click on Beatmap Creator on not submitted map, you get blank profile or latest profile loaded. Maybe don't have clickable profile on not submitted maps can avoid confusion

Screenshots or videos showing encountered issue:

https://user-images.githubusercontent.com/31996023/129478497-5dff452b-51bd-46ed-8ddb-58d13f20d391.mp4

bdach commented 3 years ago

Either that, or the author ID from web could be embedded into the beatmap files somehow if plausible.

AlexHgC commented 3 years ago

Can make it works with adding something like CreatorID: under the Creator: line on the .osu file ?

bdach commented 3 years ago

We generally avoid adding new fields to the legacy .osu file format. This may need to wait for a new one.

AlexHgC commented 3 years ago

I didn't know that a new format was planned, so yes, adding the ID on the new format can be better for Not submitted / Deleted maps and renamed users

peppy commented 3 years ago

Should probably be disabled for now. Going to bump this up in priority since it feels broken.