ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.25k stars 2.27k forks source link

Windows Snipping Tool Screenshot bugged #14546

Open ackhack opened 3 years ago

ackhack commented 3 years ago

Describe the bug:

Trying to take a Screenshot with the Windows Snipping Tool (Win + Shift + S) will reorder the UI. My Screen Resulution is 2560x1440, Second Monitor is 1920x1080. Screenshot Resulution is 2560x1440.

Screenshots or videos showing encountered issue: Untitled

osu!lazer version: 2021.828.0 Logs: performance.log runtime.log updater.log database.log network.log

bdach commented 3 years ago

Can you explain what "reorder the UI" means, exactly?

Also there's a built in screenshot key. It's F12.

ackhack commented 3 years ago

As seen in the screenshot, the ui does not look correct, as i would expect it to cover the whole screenshot area. Seems like the game thinks its in 1080p instead of 1440p while in the snipping tool mode.

peppy commented 3 years ago

I doubt this is specific to osu!. Snipping tool is not made to take exclusive fullscreen screenshots. You should probably use windows game bar.

ackhack commented 3 years ago

It works fine in Dead By Daylight and GTA5, both in exclusive fullscreen. Works in osu!stable aswell but as far as i can tell its a borderless fullscreen.

sr229 commented 3 years ago

It works fine in Dead By Daylight and GTA5, both in exclusive fullscreen. Works in osu!stable aswell but as far as i can tell its a borderless fullscreen.

Screen and Snip/Snipping tool is a hit and miss on exclusive fullscreen games, so I don't think this is something osu! can fix since this is a Windows-side bug.

loarca commented 3 years ago

I think it is still something to look more into. I mean, yes snipping tool is not meant to work with games, it works with some games but when it doesn't the screenshot is just not taken or is total black image and that's it. It should never move, alter or "reorder" the UI components or change internal canvas/resolution from the game.

But since it's not really game breaking (i mean you wouldn't be using snipping WHILE playing, and can fix it by reopening the game or switching to windowed and back to fullscreen) I believe it'd just be like a QoL fix with very low priority.

bdach commented 3 years ago

I believe it'd just be like a QoL fix with very low priority.

...which it is right now, given that the issue isn't closed. in the mean time you can use the game bar, or the built-in screenshot functionality (press F12) instead.

peppy commented 3 years ago

@loarca Are you posting here because this affected you? If so can you explain how, since you mention you wouldn't be using it for games in the first place?

It is not reordering anything. It is drawing the game into off-scren space.

loarca commented 3 years ago

It happened once. I wanted to screenshot just a portion of the screen, and I'm used to do so by pressing Win + Shift + S it happened but just didn't bother posting about it.

And I do use F12 to take full screenshots, I just wanted to take a portion of it that time and that's how I usually do it.

and ye ye ik it's not reordering anything, but did look weird

Nicolas-GE commented 2 years ago

+1, i agree that it's not a large issue and more of a QoL thing, but it's nice to be able to snip a small part of the screen right into the clipboard to paste it into a discord chat or sometwhere else

edit: i'm also having this issue on 1440p

peppy commented 2 years ago

Will add that we definitely need to investigate this further. The fact that snipping tool is seeing the game region larger than the screen means that we may be inducing extra GPU overheads if rendering is always occurring in that out-of-bounds region.