search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.35k stars 2.28k forks source link

Multiplayer Star Rating don't update with mods #14701

Open AlexHgC opened 3 years ago

AlexHgC commented 3 years ago

Describe the bug: When you use any mod that change the Star Rating, the multiplayer lobby doesn't show the new SR

Screenshots or videos showing encountered issue:

https://user-images.githubusercontent.com/31996023/132771712-974db905-1a3a-49f7-9ac9-7fbcd4382ed9.mp4

osu!lazer version: 2021.907.0

frenzibyte commented 3 years ago

That's because StarRatingRangeDisplay currently relies on b.StarDifficulty, I think it should be fine to use BeatmapDifficultyCache and consider "required mods" only for the time being.

bdach commented 3 years ago

I'm not completely convinced that is what should happen. What if ModEasy is selected to be a free mod, for instance? That potentially changes the playlist's spread.

frenzibyte commented 3 years ago

But that would of course depend on whether the players have it selected or not. I don't think it matters much right now so it can be ignored for the time being, as I mentioned above.

peppy commented 3 years ago

I think it's fine to display the "room beatmap" difficulty, since it's on the room panel. free mod can get its own difficulty display if that's sought after.

AlexHgC commented 3 years ago

But it can be a problem. Let me explain :

As you can see, this is not a freemod, but an applied mod for everyone. If the room displays the 4-star difficulty when it's in real much more with DT, people will think of finding a room at their level whereas not at all, and this will often lead to confusion. It would be really helpful if the difficulty display could update in the multiplayer room and in the lobby, to avoid confusion.

Regarding freemods, indeed having their own display would be very nice, but would it be really useful given that DT / HT and rate are not available in freemods?

peppy commented 3 years ago

@AlexHgC that is already discussed above. and is part of the proposed fix.

AlexHgC commented 3 years ago

Indeed, I had misunderstood