search

ppy / osu

rhythm is just a *click* away!
https://osu.ppy.sh
MIT License
15.24k stars 2.27k forks source link

Low-pass filter on fail screen is applied even after the fail sound stopped playing #15228

Closed bdach closed 2 years ago

bdach commented 2 years ago

It's not something that users will often do but it does feel off.

Possibly need to revisit the assumption that the filter gets applied on the game-global track mixer. Or add a separate mixer for gameplay I guess?

Discussed in https://github.com/ppy/osu/discussions/15225

Originally posted by **2minwia** October 21, 2021 If you fail a song, and then decide to open the beatmap downloader with ctrl-d, the music previews will sound muffled due to the fail screens new high pass filter, even after the fail sound itself stopped playing. how to repro: 1) fail a song 2) press ctrl-d 3) click the preview of any song 4) ?!?! it's muffled ?!?! video: https://streamable.com/cyd6r1 log: [runtime.log](https://github.com/ppy/osu/files/7389387/runtime.log)
peppy commented 2 years ago

easiest solution if removing the filter after the fail animation completes. should be a single-liner.

also it's a low pass, not high pass.